MKehayov commented on code in PR #1698:
URL: https://github.com/apache/systemds/pull/1698#discussion_r981242599
##########
src/main/java/org/apache/sysds/runtime/controlprogram/federated/monitoring/controllers/CoordinatorController.java:
##########
@@ -42,9 +43,28 @@ public FullHttpResponse create(Request request) {
@Override
public FullHttpResponse update(Request request, Long objectId) {
+ var result = coordinatorService.get(objectId);
+
+ if (result == null) {
+ return Response.notFound(Constants.NOT_FOUND_MSG);
+ }
+
var model = MapperService.getModelFromBody(request,
CoordinatorModel.class);
- model.generateMonitoringKey();
+ model.id = objectId;
+ if (model.host == null) {
Review Comment:
I do actually :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
