mboehm7 commented on code in PR #2049:
URL: https://github.com/apache/systemds/pull/2049#discussion_r1676962768


##########
src/main/java/org/apache/sysds/runtime/data/SparseBlockMCSR.java:
##########
@@ -312,8 +312,8 @@ public long size(int rl, int ru, int cl, int cu) {
                for(int i=rl; i<ru; i++)
                        if( !isEmpty(i) ) {
                                int start = posFIndexGTE(i, cl);
-                               int end = posFIndexGTE(i, cu);
-                               nnz += (start!=-1) ? (end-start) : 0;
+                               int end = posFIndexLTE(i, cu-1);
+                               nnz += (start!=-1) ? (end-start+1) : 0;

Review Comment:
   I don't see why it's not necessary for MCSR but for CSR? Could you please 
elaborate why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to