ReneEnjilian commented on code in PR #2049:
URL: https://github.com/apache/systemds/pull/2049#discussion_r1676985535
##########
src/main/java/org/apache/sysds/runtime/data/SparseBlockCOO.java:
##########
@@ -319,8 +319,8 @@ public long size(int rl, int ru, int cl, int cu) {
for(int i=rl; i<ru; i++)
if( !isEmpty(i) ) {
int start = internPosFIndexGTE(i, cl);
- int end = internPosFIndexGTE(i, cu);
- nnz += (start!=-1) ? (end-start) : 0;
+ int end = internPosFIndexLTE(i, cu-1);
Review Comment:
In case you mean the test cases from the sparse test package, no one failed.
They also worked with the way before I changed it. I just noticed that when
testing various matrices that it would not consistently produce correct
results. After changing the code the way I did the unit tests also pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
