e-strauss commented on code in PR #2119:
URL: https://github.com/apache/systemds/pull/2119#discussion_r1774709170
##########
src/main/python/systemds/operator/operation_node.py:
##########
@@ -45,27 +45,25 @@ class OperationNode(DAGNode):
_output_types: Optional[Iterable[VALID_INPUT_TYPES]]
_source_node: Optional["DAGNode"]
_brackets: bool
+ _datatype_is_unknown: bool
def __init__(self, sds_context: 'SystemDSContext', operation: str,
unnamed_input_nodes: Union[str,
Iterable[VALID_INPUT_TYPES]] =
None,
named_input_nodes: Dict[str, VALID_INPUT_TYPES] = None,
- output_type: OutputType = OutputType.MATRIX,
is_python_local_data: bool = False,
- brackets: bool = False):
+ brackets: bool = False,
Review Comment:
I added two new boolean attributes to operation_node: datatype_is_none and
datatype_is_unknown to handle operations with no return value (write, print,..)
or unkown datatype (list access), which where previously indicated by the
OutputType.NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
