e-strauss commented on code in PR #2119:
URL: https://github.com/apache/systemds/pull/2119#discussion_r1774726487
##########
src/main/python/systemds/operator/nodes/source.py:
##########
@@ -54,10 +53,7 @@ def get_func(self, sds_context, source_name) -> MethodType:
output_object = self.parse_outputs()
definition = f'def {self._name}(self{argument_string}):'
- if self._outputs is None:
- output = f'out = {output_object}(self.sds_context, {operation},
named_input_nodes=named_arguments, output_type=OutputType.NONE)'
- else:
- output = f'out = {output_object}(self.sds_context, {operation},
named_input_nodes=named_arguments)'
Review Comment:
the ifelse is not needed anymore since we can infer the output type directly
from the output_object
##########
src/main/python/systemds/operator/nodes/source.py:
##########
@@ -54,10 +53,7 @@ def get_func(self, sds_context, source_name) -> MethodType:
output_object = self.parse_outputs()
definition = f'def {self._name}(self{argument_string}):'
- if self._outputs is None:
- output = f'out = {output_object}(self.sds_context, {operation},
named_input_nodes=named_arguments, output_type=OutputType.NONE)'
- else:
- output = f'out = {output_object}(self.sds_context, {operation},
named_input_nodes=named_arguments)'
+ output = f'out = {output_object}(self.sds_context, {operation},
named_input_nodes=named_arguments)'
Review Comment:
the ifelse is not needed anymore since we can infer the output type directly
from the output_object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
