Baunsgaard commented on code in PR #2466:
URL: https://github.com/apache/systemds/pull/2466#discussion_r3218728898
##########
src/test/java/org/apache/sysds/test/component/estim/OpElemWTest.java:
##########
@@ -128,7 +129,18 @@ public void testSampleMult() {
public void testSamplePlus() {
runSparsityEstimateTest(new EstimatorSample(), m, n, sparsity,
plus);
}
-
+
+ // Row Wise Sparsity Estimator
Review Comment:
What I ment was something like :
```
OpElemWTest extends OpElemBaseTest {
}
```
and then you define a new OpElemBaseTest class that contains the variables
all the different OpElem test cases share, and define in that base test the
fundamental tests that all of the OpElem should run.
I hope this would work nicely, since it makes it easy to make the same test
flavour run in all of the variations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
