ywcb00 commented on code in PR #2466:
URL: https://github.com/apache/systemds/pull/2466#discussion_r3225575342
##########
src/test/java/org/apache/sysds/test/component/estim/OpElemWTest.java:
##########
@@ -128,7 +129,18 @@ public void testSampleMult() {
public void testSamplePlus() {
runSparsityEstimateTest(new EstimatorSample(), m, n, sparsity,
plus);
}
-
+
+ // Row Wise Sparsity Estimator
Review Comment:
Thank you again for the explanation, I gave it another thought. While I also
like such a hierarchical structure for tests in general, I cannot see the clear
advantage here--given that I understood your suggestion correctly.
There are five common variables among the test cases `m, n, sparsity, mult,
plus`, which would then be defined inside OPElemBaseTest class instead of
OPElemWTest class. I would not consolidate tests for multiplication and
addition (neither for different estimators) in one single function, as this
would break the typical structure in which tests are defined (right?). Hence, I
think such a base class would just add another class file, or have I
misunderstood something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
