Dmitry,

I just applied your patch and recalled one more reason why I didn't apply
it when I looked at it the first time. The way the provider is loaded is
should be improved. I'll update your patch and commit the fix soon. Anyway
thank you for the patch.


On Fri, Apr 20, 2012 at 3:47 PM, Dmitry Gusev <dmitry.gu...@gmail.com>wrote:

> Igor,
>
> I've attached new patch with a test case. Can you look at it, please?
>
> On Wed, Apr 18, 2012 at 11:30, Igor Drobiazko <igor.drobia...@gmail.com
> >wrote:
>
> > Well, I wouldn't say I don't care. As Kalle already said, if this is a
> > blocker for you, you should draw committer's attention here on the list,
> if
> > you feel that your issue is forgotten.
> >
> > BTW did I mention already that providing tests in a patch increases the
> > probability of the patch to be applied?
> >
> > On Wed, Apr 18, 2012 at 7:52 AM, Dmitry Gusev <dmitry.gu...@gmail.com
> > >wrote:
> >
> > > Dmitry Gusev: -1 (non-binding)
> > >
> > > I'd like to see this issue resolved in 5.3.3:
> > > https://issues.apache.org/jira/browse/TAP5-1848
> > >
> > > This is a blocker for deploying Tap5 applications to GAE.
> > >
> > > I've submitted a patch two months ago and I don't understand why its
> not
> > > resolved yet.
> > > I know Igor implemented JPA support in Tap5, and he knows about the
> issue
> > > and the patch, and looks like he doesn't care.
> > > This makes me very disappointed.
> > >
> > > On Wed, Apr 18, 2012 at 09:24, Kalle Korhonen <
> > kalle.o.korho...@gmail.com
> > > >wrote:
> > >
> > > > +1 Kalle Korhonen (non-binding)
> > > >
> > > > We should also link to the release notes, 5.3.3 at
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310833&version=12320045
> > > >
> > > > My vote's tentative so far, I just run 5.3.3 against two of my
> current
> > > > projects so far without problems, will run more tests and change if
> > > > anything comes up.
> > > >
> > > > Kalle
> > > >
> > > >
> > > > On Tue, Apr 17, 2012 at 7:44 PM, Thiago H. de Paula Figueiredo
> > > > <thiag...@gmail.com> wrote:
> > > > > Thiago H. de Paula Figueredo: +1 (binding)
> > > > >
> > > > > --
> > > > > Thiago H. de Paula Figueiredo
> > > > > Independent Java, Apache Tapestry 5 and Hibernate consultant,
> > > developer,
> > > > and
> > > > > instructor
> > > > > Owner, Ars Machina Tecnologia da Informação Ltda.
> > > > > http://www.arsmachina.com.br
> > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
> > > > > For additional commands, e-mail: dev-h...@tapestry.apache.org
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscr...@tapestry.apache.org
> > > > For additional commands, e-mail: dev-h...@tapestry.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Dmitry Gusev
> > >
> > > AnjLab Team
> > > http://anjlab.com
> > >
> >
> >
> >
> > --
> > Best regards,
> >
> > Igor Drobiazko
> > http://tapestry5.de
> > http://twitter.com/drobiazko
> >
>
>
>
> --
> Dmitry Gusev
>
> AnjLab Team
> http://anjlab.com
>



-- 
Best regards,

Igor Drobiazko
http://tapestry5.de
http://twitter.com/drobiazko

Reply via email to