DemesneGH commented on code in PR #141:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/141#discussion_r1669994664
##########
.github/workflows/ci.yml:
##########
@@ -67,39 +67,59 @@ jobs:
# Build optee_os and optee_client for qemu_v8
./build_optee_libraries.sh $HOME
-
- # Setup environment
export OPTEE_DIR=$HOME
- source environment
- # Build OP-TEE Rust examples for Arm 64-bit both host and TA
+ # Build OP-TEE Rust examples for Arm 32-bit both host and TA
+ export ARCH_HOST=arm
+ export ARCH_TA=arm
+ source environment
make -j`nproc`
- # Build OP-TEE Rust examples for Arm 64-bit host and 32-bit TA
Review Comment:
The host and TA are built separately for each example, seems building both
aarch64 and both arm32 cover all cases. If `building host as aarch64 and TA as
arm32` doesn't introduce new case I think it's okay to remove them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org
