DemesneGH commented on code in PR #141: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/141#discussion_r1670025904
########## examples/acipher-rs/host/Cargo.lock: ########## Review Comment: Rust projects usually keep the `Cargo.lock` for binaries (refernce: https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control) But considering we have two building mode, should we keep the `Cargo.lock` for `no-std` building, or just discard all Cargo.lock (maybe lack version control)? I'd prefer the first choice, any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
