ivila commented on code in PR #156:
URL: 
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/156#discussion_r1897789938


##########
examples/hello_world-rs/ta/Makefile:
##########
@@ -20,7 +20,7 @@ UUID ?= $(shell cat "../uuid.txt")
 TARGET ?= aarch64-unknown-linux-gnu
 CROSS_COMPILE ?= aarch64-linux-gnu-
 OBJCOPY := $(CROSS_COMPILE)objcopy
-LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)ld.bfd\"
+LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)gcc\"

Review Comment:
   > As you mentioned above, it's really the good point for solving another 
building issue #135.
   > 
   > BTW Could you provide some short guidance on how to build examples on ARM 
host machine (and the choice of linker) at 
https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/main/README.md#setup-building-environment
 Such as adding two sections: "building on ARM" , "cross compile on x86_64"? I 
think it's valuable for our developers.
   
   Actually there is no difference between the two environments when developing 
(same commands, same linux packages, same environments), I think I should just 
add a notification about the linker problem so that developers will know more 
about the building process (especially for the C developers, they may not know 
that there are `build script binary` and `source code binary`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org
For additional commands, e-mail: dev-h...@teaclave.apache.org

Reply via email to