b49020 commented on code in PR #156: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/156#discussion_r1898288529
########## examples/hello_world-rs/ta/Makefile: ########## @@ -20,7 +20,7 @@ UUID ?= $(shell cat "../uuid.txt") TARGET ?= aarch64-unknown-linux-gnu CROSS_COMPILE ?= aarch64-linux-gnu- OBJCOPY := $(CROSS_COMPILE)objcopy -LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)ld.bfd\" +LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)gcc\" Review Comment: Okay, that's fine. Let's do following additionally to further clarify things: 1. Add comment as @DemesneGH described above: > How about keeping this modification and add a simple comment upon this: > > ``` > -LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)ld.bfd\" > + # Configure the linker to use GCC, which works on both cross-compilation and ARM machines > +LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)gcc\" > ``` 2. Update https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/main/README.md#platforms with a subsection to say the supported host machines as `x86-64` and `arm64`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
