b49020 commented on code in PR #156:
URL:
https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/156#discussion_r1897926780
##########
examples/hello_world-rs/ta/Makefile:
##########
@@ -20,7 +20,7 @@ UUID ?= $(shell cat "../uuid.txt")
TARGET ?= aarch64-unknown-linux-gnu
CROSS_COMPILE ?= aarch64-linux-gnu-
OBJCOPY := $(CROSS_COMPILE)objcopy
-LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)ld.bfd\"
+LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)gcc\"
Review Comment:
I think it's more preferable for `optee_utee_build` crate to consume
`CROSS_COMPILE` environment variable and setup linker configuration accordingly.
And regarding documentation update, I don't think we want developers to
learn about how `optee_utee_build` crate figures out linker given the
`CROSS_COMPILE` path. Instead the documentation should rather be just about
letting the user know how to build Rust TAs in either cross-compiled
environment (x86 host) or native environment (arm64 host). I think that will
just boil down to the value of `CROSS_COMPILE` variable being empty ("") for
native compilation and ("path-to-gcc-cross-compiler") for cross compilation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
