ivila commented on code in PR #156: URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/156#discussion_r1898316277
########## examples/hello_world-rs/ta/Makefile: ########## @@ -20,7 +20,7 @@ UUID ?= $(shell cat "../uuid.txt") TARGET ?= aarch64-unknown-linux-gnu CROSS_COMPILE ?= aarch64-linux-gnu- OBJCOPY := $(CROSS_COMPILE)objcopy -LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)ld.bfd\" +LINKER_CFG := target.$(TARGET).linker=\"$(CROSS_COMPILE)gcc\" Review Comment: @b49020 How about add "**Currently, we support building on both aarch64 and amd64 host machines, and they share the same steps.**” under [Setup Building Environment](https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/main/README.md#setup-building-environment), I feel like the [Platforms section]( https://github.com/apache/incubator-teaclave-trustzone-sdk/blob/main/README.md#platforms) more like **running and debugging** rather than **building**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@teaclave.apache.org For additional commands, e-mail: dev-h...@teaclave.apache.org
