GitHub user PG1204 created a discussion: HuggingFace operator: stacked PR split - alignment check
Hi team, the MCS team would like to align on how we should be splitting the HuggingFace operator feature before opening the remaining PRs. The feature is ~5,000 lines of code across ~25 files on our `huggingFace` branch. To keep each PR reviewable, we sliced it into **9 stacked PRs** of ~500 lines each. The PRs are **sequential**: PR 2 branches off PR 1, PR 3 off PR 2, etc., so they need to land in order. PR 1 is already open as #5124. Here is the split we have in mind: <img width="2116" height="824" alt="image" src="https://github.com/user-attachments/assets/d7bb9179-59b5-4e28-870d-e68126e00e01"; /> A few notes on the choices: - **PR 2** (~800 lines) is slightly over budget because it's the smallest unit that compiles and runs end-to-end: the refactored operator skeleton plus the text-generation codegen. Splitting it further would land code that doesn't execute on its own. - **PRs 3–5** each add one task-family codegen file (image, audio + media-gen, QA/ranking) on top of the dispatcher pattern established in PR 2. These are mechanical to review once the pattern lands. - **PR 6** (~1000 lines) is the only one meaningfully over budget. It is all frontend - `hugging-face.component.{ts,html,scss,spec.ts}` plus the formly + `app.module.ts` registrations. We'd love your guidance on two things: **1. Does the overall slicing align with what you're looking for?** Anything you'd like us to regroup, merge, or split differently? **2. For PR 6 specifically:** since it's noticeably larger than the others and is all frontend, would you prefer us to split it further (e.g., separate out the `.spec.ts`, the `.scss`, or the formly/module registrations into their own PRs), or is it OK to keep the task-selector / model-browser UI together as one cohesive unit? Our concern with splitting is that the component, its styles, and its tests are tightly coupled, so fragmenting them may make individual PRs less reviewable on their own. Happy to adjust the plan before we open PRs 2-9. Thanks! GitHub link: https://github.com/apache/texera/discussions/5136 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
