[
https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178969#comment-13178969
]
Greg Fodor commented on THRIFT-1478:
------------------------------------
Hey Bryan & Andrew, I just attached an updated patch that passes the tests as
per Andrew's helpful steps above. I had a few bugs in the implementation --
first was the edge case with contexts Andrew mentioned, the second was due to
the fact that numeric values being used as keys in maps were not being quoted
properly.
> TJSONProtocol in PHP
> --------------------
>
> Key: THRIFT-1478
> URL: https://issues.apache.org/jira/browse/THRIFT-1478
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.8
> Reporter: Greg Fodor
> Priority: Minor
> Attachments: THRIFT-1478.patch, THRIFT-1478.patch
>
>
> We needed to be able to serialize and deserialize javascript thrift calls
> from within PHP, so I spent a few hours porting over the Java implementation
> of TJSONProtocol to PHP. It has not been exhaustively tested but it seems to
> be in reasonable working order. Please let me know what steps are necessary
> to get this onto trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
