[
https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191544#comment-13191544
]
Roger Meier edited comment on THRIFT-1478 at 1/23/12 10:21 PM:
---------------------------------------------------------------
This looks great! Here's the updated version which integrates the test with
automake and friends [^THRIFT-1478_incl_make_check.patch]
I have the folling issue now:
{noformat}
make[3]: Entering directory `/home/roger/thrift/lib/php/test'
mkdir -p ../src/packages
../../../compiler/cpp/thrift --gen php -r --out ../src/packages
../../../test/ThriftTest.thrift
/usr/bin/phpunit protocol/TestTJSONProtocol.php
PHPUnit 3.4.14 by Sebastian Bergmann.
..................F.......F.....
Time: 1 second, Memory: 6.75Mb
There were 2 failures:
1) TestTJSONProtocol::testDouble_Read
Failed asserting that <double:3.1415926535898> matches expected
<double:3.1415926535898>.
/home/roger/thrift/lib/php/test/protocol/TestTJSONProtocol.php:305
2) TestTJSONProtocol::testSet_Read
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array
(
[0] => 1
- [1] => 2
- [2] => 3
+ [1] => 1
+ [2] => 1
)
/home/roger/thrift/lib/php/test/protocol/TestTJSONProtocol.php:422
FAILURES!
Tests: 32, Assertions: 30, Failures: 2.
make[3]: *** [check] Error 1
{noformat}
-roger
was (Author: roger.meier):
This looks great! Here's the updated version which integrates the test with
automake and friends [^THRIFT-1249_incl_make_check.patch]
I have the folling issue now:
{noformat}
make[3]: Entering directory `/home/roger/thrift/lib/php/test'
mkdir -p ../src/packages
../../../compiler/cpp/thrift --gen php -r --out ../src/packages
../../../test/ThriftTest.thrift
/usr/bin/phpunit protocol/TestTJSONProtocol.php
PHPUnit 3.4.14 by Sebastian Bergmann.
..................F.......F.....
Time: 1 second, Memory: 6.75Mb
There were 2 failures:
1) TestTJSONProtocol::testDouble_Read
Failed asserting that <double:3.1415926535898> matches expected
<double:3.1415926535898>.
/home/roger/thrift/lib/php/test/protocol/TestTJSONProtocol.php:305
2) TestTJSONProtocol::testSet_Read
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array
(
[0] => 1
- [1] => 2
- [2] => 3
+ [1] => 1
+ [2] => 1
)
/home/roger/thrift/lib/php/test/protocol/TestTJSONProtocol.php:422
FAILURES!
Tests: 32, Assertions: 30, Failures: 2.
make[3]: *** [check] Error 1
{noformat}
-roger
> TJSONProtocol in PHP
> --------------------
>
> Key: THRIFT-1478
> URL: https://issues.apache.org/jira/browse/THRIFT-1478
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.8
> Reporter: Greg Fodor
> Assignee: Roger Meier
> Priority: Minor
> Attachments: THRIFT-1478.patch, THRIFT-1478.patch, THRIFT-1478.patch,
> THRIFT-1478.patch, THRIFT-1478_incl_make_check.patch
>
>
> We needed to be able to serialize and deserialize javascript thrift calls
> from within PHP, so I spent a few hours porting over the Java implementation
> of TJSONProtocol to PHP. It has not been exhaustively tested but it seems to
> be in reasonable working order. Please let me know what steps are necessary
> to get this onto trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
