[
https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Grumet updated THRIFT-1478:
----------------------------------
Attachment: THRIFT-1478.patch
All right, reverting to the older version of phpunit reproduces the errors.
The attached patch is a re-do of the patch file that passes in both old and new
phpunit versions. Not sure what was up with the pi comparison, but replacing
the function call with a literal fixed it. The testSet error was legit; fixed
now. Also, I added a new test for strings that end in double-backslash -- this
was a bug that is now fixed.
The patchfile does not include the extra makefile stuff...hopefully it's easy
for you to reapply that piece. Thanks!
> TJSONProtocol in PHP
> --------------------
>
> Key: THRIFT-1478
> URL: https://issues.apache.org/jira/browse/THRIFT-1478
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.8
> Reporter: Greg Fodor
> Assignee: Roger Meier
> Priority: Minor
> Attachments: THRIFT-1478.patch, THRIFT-1478.patch, THRIFT-1478.patch,
> THRIFT-1478.patch, THRIFT-1478.patch, THRIFT-1478_incl_make_check.patch
>
>
> We needed to be able to serialize and deserialize javascript thrift calls
> from within PHP, so I spent a few hours porting over the Java implementation
> of TJSONProtocol to PHP. It has not been exhaustively tested but it seems to
> be in reasonable working order. Please let me know what steps are necessary
> to get this onto trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
