[
https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565529#comment-13565529
]
Ben Craig commented on THRIFT-1846:
-----------------------------------
The original patch is fine. I foolishly assumed that TSocket.cpp included
TSocket.h very early in the file, as opposed to being one of the last #includes.
If you were going to try an alternative patch, I would try moving the #include
"TSocket.h" so that it immediately follows the #include <config.h>
> Restore socket.h header to support builds with Android NDK
> ----------------------------------------------------------
>
> Key: THRIFT-1846
> URL: https://issues.apache.org/jira/browse/THRIFT-1846
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Building with Android Linux NDK R8D (and, it looks like,
> all previous NDKs)
> Reporter: Nate Rosenblum
> Fix For: 0.9
>
> Attachments:
> 0001-Restore-socket.h-include-to-support-Android-builds.patch
>
>
> Unlike every other rational un.h that I've seen, the sys/un.h (actually
> linux/un.h) distributed with the Android NDK doesn't define sa_family_t or
> include another header that does. Removal of socket.h in THRIFT-1740 broke
> the Android build.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
