[
https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641172#comment-13641172
]
Brian commented on THRIFT-1846:
-------------------------------
Thanks for the patch.
For reference, I discovered that this issue will be fixed on the android side
as described here:
https://android-review.googlesource.com/#/c/55031/
https://android-review.googlesource.com/#/c/55031/2/ndk/platforms/android-3/include/sys/un.h
> Restore socket.h header to support builds with Android NDK
> ----------------------------------------------------------
>
> Key: THRIFT-1846
> URL: https://issues.apache.org/jira/browse/THRIFT-1846
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9, 1.0
> Environment: Building with Android Linux NDK R8D (and, it looks like,
> all previous NDKs)
> Reporter: Nate Rosenblum
> Assignee: Nicolas Trésegnie
> Fix For: 1.0
>
> Attachments:
> 0001-Restore-socket.h-include-to-support-Android-builds.patch,
> socket-include-moved-back-to-cpp.patch
>
>
> Unlike every other rational un.h that I've seen, the sys/un.h (actually
> linux/un.h) distributed with the Android NDK doesn't define sa_family_t or
> include another header that does. Removal of socket.h in THRIFT-1740 broke
> the Android build.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
