[ https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576342#comment-13576342 ]
Ben Craig commented on THRIFT-1846: ----------------------------------- Just make sure that sockaddr, sockaddr_in, sockaddr_in6, addrinfo, timespec, and timeval all have their appropriate headers included on all platforms. You don't want to force other clients to include headers in a specific order. > Restore socket.h header to support builds with Android NDK > ---------------------------------------------------------- > > Key: THRIFT-1846 > URL: https://issues.apache.org/jira/browse/THRIFT-1846 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9 > Environment: Building with Android Linux NDK R8D (and, it looks like, > all previous NDKs) > Reporter: Nate Rosenblum > Fix For: 0.9 > > Attachments: > 0001-Restore-socket.h-include-to-support-Android-builds.patch, > socket-include-moved-back-to-cpp.patch > > > Unlike every other rational un.h that I've seen, the sys/un.h (actually > linux/un.h) distributed with the Android NDK doesn't define sa_family_t or > include another header that does. Removal of socket.h in THRIFT-1740 broke > the Android build. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira