[ https://issues.apache.org/jira/browse/THRIFT-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636922#comment-13636922 ]
Carl Yeksigian commented on THRIFT-1930: ---------------------------------------- Looks good. However, wondering why the types in the compact serializer are unsigned; seems like that should be signed as well. > C# generates unsigned byte for Thrift "byte" type > ------------------------------------------------- > > Key: THRIFT-1930 > URL: https://issues.apache.org/jira/browse/THRIFT-1930 > Project: Thrift > Issue Type: Bug > Components: C# - Compiler, C# - Library > Reporter: Jens Geyer > Assignee: Jens Geyer > Labels: bug > Fix For: 1.0 > > Attachments: > THRIFT-1930_CSharp_generates_unsigned_byte_for_Thrift_byte_type.patch > > > Given the code > {code} > struct test { > 1: byte field > } > {code} > the C# Generator generates > {code} > public partial class test : TBase > { > private byte _field; > // more code > } > {code} > which is wrong, as all Thrift integer types are considered signed. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira