[
https://issues.apache.org/jira/browse/THRIFT-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13638414#comment-13638414
]
Jens Geyer commented on THRIFT-1930:
------------------------------------
First of all thanks for reviewing this.
{quote}Since it is a private class, thought it would clean up the code without
breaking the API.{quote}
I'm not so sure about the code cleanup aspect, remember the
Write/ReadBinary(byte[]) methods still use byte. So some chances are that
changes there will break anything while getting only less benefit out of it. I
would be happy if we only get the unsigned problem adressed correctly without
overlooking anything.
I'd propose to open a separate (enhancement) ticket for cleanup of the existing
C# code base if that makes sense to you.
> C# generates unsigned byte for Thrift "byte" type
> -------------------------------------------------
>
> Key: THRIFT-1930
> URL: https://issues.apache.org/jira/browse/THRIFT-1930
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler, C# - Library
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Labels: bug
> Fix For: 1.0
>
> Attachments:
> THRIFT-1930_CSharp_generates_unsigned_byte_for_Thrift_byte_type.patch
>
>
> Given the code
> {code}
> struct test {
> 1: byte field
> }
> {code}
> the C# Generator generates
> {code}
> public partial class test : TBase
> {
> private byte _field;
> // more code
> }
> {code}
> which is wrong, as all Thrift integer types are considered signed.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
