[ https://issues.apache.org/jira/browse/THRIFT-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13643789#comment-13643789 ]
Hudson commented on THRIFT-1930: -------------------------------- Integrated in Thrift #643 (See [https://builds.apache.org/job/Thrift/643/]) THRIFT-1930: C# generates unsigned byte for Thrift "byte" type (Revision f509df9c969f71d360e7c1394d0d73cb6ab9955c) Result = ABORTED jensg : https://git-wip-us.apache.org/repos/asf?p=thrift.git&a=commit&h=f509df9c969f71d360e7c1394d0d73cb6ab9955c Files : * lib/csharp/src/Protocol/TProtocol.cs * lib/csharp/src/Protocol/TJSONProtocol.cs * lib/csharp/src/Protocol/TCompactProtocol.cs * lib/csharp/src/Protocol/TBinaryProtocol.cs * lib/csharp/src/Thrift.csproj * compiler/cpp/src/generate/t_csharp_generator.cc > C# generates unsigned byte for Thrift "byte" type > ------------------------------------------------- > > Key: THRIFT-1930 > URL: https://issues.apache.org/jira/browse/THRIFT-1930 > Project: Thrift > Issue Type: Bug > Components: C# - Compiler, C# - Library > Reporter: Jens Geyer > Assignee: Jens Geyer > Labels: bug > Fix For: 1.0 > > Attachments: > THRIFT-1930_CSharp_generates_unsigned_byte_for_Thrift_byte_type.patch > > > Given the code > {code} > struct test { > 1: byte field > } > {code} > the C# Generator generates > {code} > public partial class test : TBase > { > private byte _field; > // more code > } > {code} > which is wrong, as all Thrift integer types are considered signed. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira