[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867064#comment-13867064
]
Pierre Lamot commented on THRIFT-2205:
--------------------------------------
This look much better. (beware though, you have commited the patch 0001 itself
within the patch 0002)
in TJSONProtocol:
{code}
var transBuf = this.trans.borrow();
if (transBuf.readIndex >= transBuf.writeIndex) {
throw new InputBufferUnderrunError();
}
{code}
but in TFramedTransport:
{code}
borrow: function() {
return { buf: this.inBuf, readIndex: this.readPos, writeIndex: 0 };
},
{code}
so it always fails
I think borrow should returns something like
{code}
borrow: function() {
return { buf: this.inBuf, readIndex: this.readPos, writeIndex:
this.inBuf.length };
},
{code}
> Node.js Test Server to support test.js JavaScript Browser test and sundry
> fixes
> -------------------------------------------------------------------------------
>
> Key: THRIFT-2205
> URL: https://issues.apache.org/jira/browse/THRIFT-2205
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Library, Node.js - Library
> Affects Versions: 1.0
> Environment: All
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Labels: node, nodejs
> Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch,
> 0002-node-client-server-test-update.patch
>
>
> Adds lib/nodejs/test/testsvr.js
> This server depends on ThriftTest[.js] and runs clean with test.js in the
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes
> overflow on Javascript I64 tests. Improves static_server header output.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
