[ 
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867498#comment-13867498
 ] 

Randy Abernethy commented on THRIFT-2205:
-----------------------------------------

Just cloned the trunk and applied all 6 patches attached here. Then ran the 
following tests:
 - thrift/test/nodejs/server.js   (bin/frame)
 - thrift/test/nodejs/server_bin.js   (bin/buf)
 - thrift/test/nodejs/server_json.js   (json/buf)
 - thrift/test/nodejs/server_json_frame.js   (json/frame)
 - thrift/test/nodejs/server_http.js   (json/frame,  Browser -> Node)

All passed multiple runs.
+1


> Node.js Test Server to support test.js JavaScript Browser test and sundry 
> fixes
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-2205
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2205
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Library, Node.js - Library
>    Affects Versions: 1.0
>         Environment: All
>            Reporter: Randy Abernethy
>            Assignee: Randy Abernethy
>            Priority: Minor
>              Labels: node, nodejs
>         Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch, 
> 0002-node-Bin-Frame-client-server-test-update.patch, 
> 0003-node-throwed-error-should-be-instanciated.patch, 
> 0004-node-fix-TJSONProtocol-parser.patch, 
> 0005-node-tests-for-json-frame-and-bin-buf.patch, 
> 0006-node-fix-multiplexed-processor-for-buffered-transpor.patch
>
>
> Adds lib/nodejs/test/testsvr.js 
> This server depends on ThriftTest[.js] and runs clean with test.js in the 
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes 
> overflow on Javascript I64 tests. Improves static_server header output.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to