Github user ben-craig commented on the pull request:
https://github.com/apache/thrift/pull/86#issuecomment-39373713
This should go in one of three directions:
Option 1: completely abandon this path
Option 2: Be more thorough in calling TWinsockSingleton::create(). You're
calling it for serverSocket::listen, but you aren't doing anything on client
creation. I don't particularly care for this approach, because it adds
overhead that isn't strictly required.
Option 3: Make a platform abstraction for TWinsockSingleton::create() that
can be called on all OSes. It would be a no op on posix platforms, but at
least then you don't need ifdefs in your code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
