[ 
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979979#comment-13979979
 ] 

Andrew Cox commented on THRIFT-2457:
------------------------------------

Ben, the problem I think is that receivers normally "skip" fields because it 
doesn't know about a field with that ID, but it does have to know the type to 
skip it (because it reads and discards the data). All the types have different 
sizes, so you can't really read and discard a new type without knowing 
something about how big it is... :/

I agree that having an error message describing *specifically* what happened 
would be marginally better (e.g. "received response in version 2, but only know 
how to parse version 1 messages") but as it stands now, old clients would 
already get something like "protocol error: unknown field type 15" or something 
similar, which will indicate that the response had an unknown type.

If it's simply a matter of a better error message, then I think it's not worth 
the effort that would be involved in bumping the version and the risk this 
would have at creating new problems in cases NOT involving float that would 
continue to work just fine, if we don't bump the version. But maybe I'm missing 
something more valuable we can get out of the version bump?


> fbthrift float
> --------------
>
>                 Key: THRIFT-2457
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2457
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
>            Reporter: Roger Meier
>            Priority: Minor
>             Fix For: 1.0
>
>
> I'm interested into the fbthrift FLOAT data type.
> Which languages are supported?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to