[
https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980240#comment-13980240
]
Ben Craig commented on THRIFT-2457:
-----------------------------------
Here are some questions we need to explicitly answer...
1. Are we going to break protocol compatibility?
* Note: adding a float type identifier naively will cause a protocol break
2. If we break protocol compatibility, how are we going to ease client
migration?
* Maybe this is through Thrift compiler warnings, or bumping protocol versions,
or something else, but these are all mitigations and not "fixes"
3. If we break protocol compatibility, are we going to do anything to prevent
future breakages?
* Maybe add a generic type-length-value type, to aid skipping fields in the
future.
4. If we aren't going to break protocol compatibility, how are we going to do
so, and what maintenance trade offs do these changes imply?
* For example, making float look like i32 might work... but it would be
unusual, and possibly error prone to maintain.
> fbthrift float
> --------------
>
> Key: THRIFT-2457
> URL: https://issues.apache.org/jira/browse/THRIFT-2457
> Project: Thrift
> Issue Type: Sub-task
> Components: Build Process, C++ - Compiler, C++ - Library, Test Suite
> Reporter: Roger Meier
> Priority: Minor
> Fix For: 1.0
>
>
> I'm interested into the fbthrift FLOAT data type.
> Which languages are supported?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
