Hey Chamila, We should also add the compact protocol to the node.js cross tests.
-Randy On Wed, May 21, 2014 at 10:44 AM, Chamila Wijayarathna < cdwijayarat...@gmail.com> wrote: > Hi Roger, > I think now we have a good automated test reporting? Do I have do to any > modification on this? > If not what should I do next? Do you have any suggestions on tasks to > implement next. > Since in cross language test suite, it only tests nodejs with cpp, I think > nodejs-nodejs, nodejs-java and java-nodejs tests are suitable as next task. > What do you think? > Thank You! > > > On Fri, May 16, 2014 at 9:17 PM, Chamila Wijayarathna < > cdwijayarat...@gmail.com> wrote: > > > Patch attached at https://issues.apache.org/jira/browse/THRIFT-2534. > > > > > > On Fri, May 16, 2014 at 9:07 PM, Chamila Wijayarathna < > > cdwijayarat...@gmail.com> wrote: > > > >> Sorry, status.html is attached here. > >> > >> > >> On Fri, May 16, 2014 at 9:06 PM, Chamila Wijayarathna < > >> cdwijayarat...@gmail.com> wrote: > >> > >>> Hi Roger, > >>> I generated status.html I have attached with this. Please let me know > >>> what else should be added here. > >>> Thank You! > >>> > >>> > >>> On Fri, May 16, 2014 at 1:19 PM, Chamila Wijayarathna < > >>> cdwijayarat...@gmail.com> wrote: > >>> > >>>> Created a sub task and added patch. > >>>> https://issues.apache.org/jira/browse/THRIFT-2534 > >>>> > >>>> > >>>> On Fri, May 16, 2014 at 1:16 PM, Roger Meier <ro...@bufferoverflow.ch > >wrote: > >>>> > >>>>> yes, just creat a sub Task for THRIFT-847 > >>>>> > >>>>> > >>>>> thanks > >>>>> roger > >>>>> > >>>>> Quoting Chamila Wijayarathna <cdwijayarat...@gmail.com>: > >>>>> > >>>>> Hi Roger, > >>>>>> I'll start working on that. > >>>>>> Shall I create a Jira for this and add patch for current stuff > there? > >>>>>> Than You. > >>>>>> > >>>>>> > >>>>>> > >>>>>> On Thu, May 15, 2014 at 3:52 AM, Roger Meier < > ro...@bufferoverflow.ch > >>>>>> >wrote: > >>>>>> > >>>>>> Hi Chamila > >>>>>>> > >>>>>>> generating this as an additional result out of test.sh is good > first > >>>>>>> step. > >>>>>>> > >>>>>>> attached is a template for the second step: > >>>>>>> git apply test_status.diff > >>>>>>> > >>>>>>> it uses jquery datatables, a simple and useful table control > >>>>>>> we can add filter functions to the table, etc. > >>>>>>> > >>>>>>> you can generate status.html > >>>>>>> or generate status.json and load the table within status.html from > >>>>>>> status.json > >>>>>>> (e.g. use https://datatables.net/manual/data#Objects as > >>>>>>> initialization > >>>>>>> method) > >>>>>>> > >>>>>>> thanks > >>>>>>> roger > >>>>>>> > >>>>>>> > >>>>>>> Quoting Chamila Wijayarathna <cdwijayarat...@gmail.com>: > >>>>>>> > >>>>>>> Hi Roger, > >>>>>>> > >>>>>>>> As we discussed earlier I have changed test.sh to write results of > >>>>>>>> cross > >>>>>>>> language test run to a status.md file. I have attached a sample > >>>>>>>> status.mdgenerated. > >>>>>>>> I observed that in commit "THRIFT-847 Test Framework harmonization > >>>>>>>> across > >>>>>>>> all languages (commit 4edac7ff085e4bd28096fef3cf8234e4991544ff)" > >>>>>>>> you have > >>>>>>>> wrote results of failed test to an error.log file. Are we planning > >>>>>>>> to keep > >>>>>>>> both status.md and error.log or only one from them? > >>>>>>>> What do you think about the format of status.md? I am only > writing > >>>>>>>> success/failure, no any description in failure. Is there any thing > >>>>>>>> else > >>>>>>>> needed to be added or is this enough for now? > >>>>>>>> Thank You! > >>>>>>>> > >>>>>>>> -- > >>>>>>>> *Chamila Dilshan Wijayarathna,* > >>>>>>>> > >>>>>>>> SMIEEE, SMIESL, > >>>>>>>> Undergraduate, > >>>>>>>> Department of Computer Science and Engineering, > >>>>>>>> University of Moratuwa. > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> > >>>>>> > >>>>>> -- > >>>>>> *Chamila Dilshan Wijayarathna,* > >>>>>> SMIEEE, SMIESL, > >>>>>> Undergraduate, > >>>>>> Department of Computer Science and Engineering, > >>>>>> University of Moratuwa. > >>>>>> > >>>>> > >>>>> > >>>> > >>>> > >>>> -- > >>>> *Chamila Dilshan Wijayarathna,* > >>>> > >>>> SMIEEE, SMIESL, > >>>> Undergraduate, > >>>> Department of Computer Science and Engineering, > >>>> University of Moratuwa. > >>>> > >>> > >>> > >>> > >>> -- > >>> *Chamila Dilshan Wijayarathna,* > >>> SMIEEE, SMIESL, > >>> Undergraduate, > >>> Department of Computer Science and Engineering, > >>> University of Moratuwa. > >>> > >> > >> > >> > >> -- > >> *Chamila Dilshan Wijayarathna,* > >> SMIEEE, SMIESL, > >> Undergraduate, > >> Department of Computer Science and Engineering, > >> University of Moratuwa. > >> > > > > > > > > -- > > *Chamila Dilshan Wijayarathna,* > > SMIEEE, SMIESL, > > Undergraduate, > > Department of Computer Science and Engineering, > > University of Moratuwa. > > > > > > -- > *Chamila Dilshan Wijayarathna,* > SMIEEE, SMIESL, > Undergraduate, > Department of Computer Science and Engineering, > University of Moratuwa. >
