[
https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088826#comment-14088826
]
ASF GitHub Bot commented on THRIFT-2578:
----------------------------------------
Github user cdwijayarathna commented on a diff in the pull request:
https://github.com/apache/thrift/pull/173#discussion_r15918465
--- Diff: test/tests.json ---
@@ -4,7 +4,7 @@
"description": "Python TestClient",
"lib": "py",
"executable": "py/TestClient.py",
--- End diff --
Here we use path relative to script which execute the command. By using
that, it is easy to get the absolute path of executable, which have to pass to
subprocess command, since we can get the absolute path of current directory
easily. It may be hard to find absolute path if we use path from root. For
files in lib folder, we have used '../lib/nodejs/test/client.js' which works
without any issue.
> Moving 'make cross' from test.sh to test.py
> -------------------------------------------
>
> Key: THRIFT-2578
> URL: https://issues.apache.org/jira/browse/THRIFT-2578
> Project: Thrift
> Issue Type: Sub-task
> Components: Test Suite
> Reporter: Chamila Dilshan Wijayarathna
> Assignee: Roger Meier
> Labels: gsoc2014
> Attachments:
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0010-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch,
> 0011-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch
>
>
> Since test.sh has too much redundant code, we are planning to move cross
> language test suite to test.py. By moving this, other than removing
> redundancy we expect to achieve following.
> seperate file to define the tests for server and clients
> cross platform (=> become able to run it on windows)
> remove limitations of scripting language.
> [~roger.meier] has added a initial version of this. Following are yet to do.
> reporting page
> log files
> add languages
> run on windows
--
This message was sent by Atlassian JIRA
(v6.2#6252)
