[ 
https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089145#comment-14089145
 ] 

ASF GitHub Bot commented on THRIFT-2578:
----------------------------------------

Github user cdwijayarathna commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/173#discussion_r15930173
  
    --- Diff: test/test.py ---
    @@ -90,14 +92,18 @@ def runServiceTest(test_name, server_lib, 
server_executable, server_extra_args,
     #      which.append('-v')
       if server_lib == 'java':
         server_args.append('\"')
    +  elif server_lib == 'py':
    +    server_args.append('--genpydir=' + relfile('py/gen-py'))
    --- End diff --
    
    Okay, I'll think of a way how to add whole arguement to tests.json. I need 
to get location part from it and compute absolute path from it again and then 
join them. So anyway I will have to get  '--genpydir=' and 'py/gen-py' as 2 
seperate arguements.


> Moving 'make cross' from test.sh to test.py
> -------------------------------------------
>
>                 Key: THRIFT-2578
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2578
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Test Suite
>            Reporter: Chamila Dilshan Wijayarathna
>            Assignee: Roger Meier
>              Labels: gsoc2014
>         Attachments: 
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, 
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, 
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, 
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, 
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, 
> 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, 
> 0010-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, 
> 0011-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch
>
>
> Since test.sh has too much redundant code, we are planning to move cross 
> language test suite to test.py. By moving this, other than removing 
> redundancy we expect to achieve following.
> seperate file to define the tests for server and clients
> cross platform (=> become able to run it on windows)
> remove limitations of scripting language.
> [~roger.meier] has added a initial version of this. Following are yet to do.
> reporting page
> log files
> add languages
> run on windows



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to