[ https://issues.apache.org/jira/browse/THRIFT-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099011#comment-14099011 ]
ASF GitHub Bot commented on THRIFT-2578: ---------------------------------------- GitHub user cdwijayarathna opened a pull request: https://github.com/apache/thrift/pull/191 THRIFT-2578 Moving 'make cross' from test.sh to test.py --server attribute and --client attribute added. Uses comma separated server and client inputs (eg: --server=cpp,py , --client=hs,java) instead of seperate arguements. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cdwijayarathna/thrift THRIFT-2578 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/191.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #191 ---- commit 0133a3904344e3ea6d85e34199ab23c9b6e28c42 Author: cdwijayarathna <cdwijayarat...@gmail.com> Date: 2014-08-15T18:12:20Z THRIFT-2578 Moving 'make cross' from test.sh to test.py ---- > Moving 'make cross' from test.sh to test.py > ------------------------------------------- > > Key: THRIFT-2578 > URL: https://issues.apache.org/jira/browse/THRIFT-2578 > Project: Thrift > Issue Type: Sub-task > Components: Test Suite > Reporter: Chamila Dilshan Wijayarathna > Assignee: Roger Meier > Labels: gsoc2014 > Attachments: > 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, > 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, > 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, > 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, > 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, > 0001-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, > 0010-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch, > 0011-THRIFT-2578-Moving-make-cross-from-test.sh-to-test.p.patch > > > Since test.sh has too much redundant code, we are planning to move cross > language test suite to test.py. By moving this, other than removing > redundancy we expect to achieve following. > seperate file to define the tests for server and clients > cross platform (=> become able to run it on windows) > remove limitations of scripting language. > [~roger.meier] has added a initial version of this. Following are yet to do. > reporting page > log files > add languages > run on windows -- This message was sent by Atlassian JIRA (v6.2#6252)