[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273910#comment-14273910
]
Randy Abernethy commented on THRIFT-2940:
-----------------------------------------
Hello Radoslaw,
Apache thrift supports npm install of the NodeJS lib from its git repo:
1. The registration is here: https://www.npmjs.com/package/thrift
2. The package file is here:
{noformat}
randy@thrift-mint ~/thrift $ ls -l lib/nodejs/package.json
-rwxr-xr-x 1 randy randy 997 Jan 12 10:17 lib/nodejs/package.json
{noformat}
3. Running "$ npm install thrift" on my Linux box produces:
{noformat}
randy@thrift-mint ~/tmp/npmtest $ npm install thrift
npm http GET https://registry.npmjs.org/thrift
npm http 200 https://registry.npmjs.org/thrift
npm http GET https://registry.npmjs.org/node-int64
npm http GET https://registry.npmjs.org/q
...
npm http 200 https://registry.npmjs.org/uglify-js
thrift@0.9.2 node_modules/thrift
├── node-int64@0.3.3
├── q@1.0.1
└── nodeunit@0.8.8 (tap@0.4.13)
randy@thrift-mint ~/tmp/npmtest $ ls -l node_modules/thrift/
total 108
drwxr-xr-x 2 randy randy 4096 Jan 12 10:19 examples
drwxr-xr-x 3 randy randy 4096 Nov 4 17:50 lib
-rw-r--r-- 1 randy randy 15745 Nov 10 09:06 Makefile
-rwxr-xr-x 1 randy randy 1131 Nov 4 17:50 Makefile.am
-rw-r--r-- 1 randy randy 15781 Nov 10 09:06 Makefile.in
drwxr-xr-x 6 randy randy 4096 Jan 12 10:19 node_modules
-rwxr-xr-x 1 randy randy 3444 Jan 12 10:19 package.json
-rw-r--r-- 1 randy randy 2330 Nov 4 17:50 README.md
drwxr-xr-x 2 randy randy 4096 Jan 12 10:19 test
-rw-r--r-- 1 randy randy 47902 Nov 14 09:53 thrift-0.9.2.tgz
{noformat}
Maybe I am missing the point of this issue. Help me understand if there is a
problem we need to address.
Best,
Randy
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory
> -----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2940
> URL: https://issues.apache.org/jira/browse/THRIFT-2940
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Radoslaw Gruchalski
>
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory. Currently, result is similar to:
> {noformat}
> drone:gossiperl-client-js rad$ npm install
> npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh
> npm ERR! Error: ENOENT, open
> '/var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json'
> npm ERR! If you need help, you may report this log at:
> npm ERR! <http://github.com/isaacs/npm/issues>
> npm ERR! or email it to:
> npm ERR! <n...@googlegroups.com>
> npm ERR! System Darwin 14.0.0
> npm ERR! command "node" "/usr/local/bin/npm" "install"
> npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js
> npm ERR! node -v v0.10.22
> npm ERR! npm -v 1.3.14
> npm ERR! path
> /var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json
> npm ERR! code ENOENT
> npm ERR! errno 34
> npm ERR!
> npm ERR! Additional logging details can be found in:
> npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log
> npm ERR! not ok code 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
