[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273069#comment-14273069
]
ASF GitHub Bot commented on THRIFT-2940:
----------------------------------------
GitHub user radekg opened a pull request:
https://github.com/apache/thrift/pull/354
THRIFT-2940: Package json
Add package.json in the top level directory. This allows installing thrift
as NPM module from git.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radekg/thrift package-json
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #354
----
commit 8c94a6e62690a87cb2150bb07d21708fd7941e46
Author: radekg <ra...@gruchalski.com>
Date: 2015-01-01T19:35:01Z
Initialise tpos and tstack in the Protocol constructor so writing to a
protocol without a message does not fail.
commit 4cfe690bc0d0bde0eab01212d5cffb636afa19b0
Author: radekg <ra...@gruchalski.com>
Date: 2015-01-11T10:51:40Z
Merge remote-tracking branch 'upstream/master'
commit aa51164a789edb80a190bdb6edc0c5154c87953d
Author: radekg <ra...@gruchalski.com>
Date: 2015-01-11T21:29:16Z
Add top level package.json allows installing thrift as npm module from git.
----
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory
> -----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2940
> URL: https://issues.apache.org/jira/browse/THRIFT-2940
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Radoslaw Gruchalski
>
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory. Currently, result is similar to:
> {noformat}
> drone:gossiperl-client-js rad$ npm install
> npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh
> npm ERR! Error: ENOENT, open
> '/var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json'
> npm ERR! If you need help, you may report this log at:
> npm ERR! <http://github.com/isaacs/npm/issues>
> npm ERR! or email it to:
> npm ERR! <n...@googlegroups.com>
> npm ERR! System Darwin 14.0.0
> npm ERR! command "node" "/usr/local/bin/npm" "install"
> npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js
> npm ERR! node -v v0.10.22
> npm ERR! npm -v 1.3.14
> npm ERR! path
> /var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json
> npm ERR! code ENOENT
> npm ERR! errno 34
> npm ERR!
> npm ERR! Additional logging details can be found in:
> npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log
> npm ERR! not ok code 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
