[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273968#comment-14273968
]
Randy Abernethy commented on THRIFT-2940:
-----------------------------------------
Ah, I see. The original reason we put the package.json file in the nodejs
subdir was to avoid putting node stuff in the Thrift root. With so many
languages the root begins to get murky if every lang locates its language
specific files in the eco system root. Kind of crazy that npm lets you point to
a package file in a subdir for install but not for dependency.
Bower gave us no choice at all, which is the only reason it is in the root. The
other problem with bower in the root is that when you bower install thrift
(expecting to get a nice compact JS lib) you get the entire apache thrift repo!
Not pretty.
I am ok with moving (or duplicating) the package.json into the thrift root but
I know others may have concerns.
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory
> -----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2940
> URL: https://issues.apache.org/jira/browse/THRIFT-2940
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Radoslaw Gruchalski
>
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory. Currently, result is similar to:
> {noformat}
> drone:gossiperl-client-js rad$ npm install
> npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh
> npm ERR! Error: ENOENT, open
> '/var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json'
> npm ERR! If you need help, you may report this log at:
> npm ERR! <http://github.com/isaacs/npm/issues>
> npm ERR! or email it to:
> npm ERR! <n...@googlegroups.com>
> npm ERR! System Darwin 14.0.0
> npm ERR! command "node" "/usr/local/bin/npm" "install"
> npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js
> npm ERR! node -v v0.10.22
> npm ERR! npm -v 1.3.14
> npm ERR! path
> /var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json
> npm ERR! code ENOENT
> npm ERR! errno 34
> npm ERR!
> npm ERR! Additional logging details can be found in:
> npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log
> npm ERR! not ok code 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
