[
https://issues.apache.org/jira/browse/THRIFT-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606537#comment-14606537
]
ASF GitHub Bot commented on THRIFT-3211:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/532
THRIFT-3211: add php client compact protocol to make cross test
Note compact passes but json fails; tracking that failure in a related
defect in Jira.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift
bugfix/THRIFT-3211-make-cross-php-compact-protocol
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/532.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #532
----
commit 709577eb4c08aef916e483c5a617b939b73dff74
Author: Jim King <jim.k...@simplivity.com>
Date: 2015-06-29T22:12:48Z
THRIFT-3211: add php client compact protocol to make cross test
----
> Add make cross support for php TCompactProtocol
> -----------------------------------------------
>
> Key: THRIFT-3211
> URL: https://issues.apache.org/jira/browse/THRIFT-3211
> Project: Thrift
> Issue Type: Test
> Components: PHP - Library, Test Suite
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> In working on THRIFT-878 I found that the PHP client does not test
> TCompactProtocol in {{make cross}}. I fixed the php test client locally and
> was able to get it to pass when using cpp as the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
