[ https://issues.apache.org/jira/browse/THRIFT-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14609078#comment-14609078 ]
ASF GitHub Bot commented on THRIFT-3211: ---------------------------------------- Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/532#issuecomment-117342629 I removed all PHP make cross exclusions except for "go-php" because they all fail. "go" in general seems to have some fundamental issues playing nice with the other implementations. There are a total of 156 test exclusions involving "go". > Add make cross support for php TCompactProtocol > ----------------------------------------------- > > Key: THRIFT-3211 > URL: https://issues.apache.org/jira/browse/THRIFT-3211 > Project: Thrift > Issue Type: Test > Components: PHP - Library, Test Suite > Affects Versions: 0.9.2 > Reporter: James E. King, III > Assignee: James E. King, III > Priority: Minor > > In working on THRIFT-878 I found that the PHP client does not test > TCompactProtocol in {{make cross}}. I fixed the php test client locally and > was able to get it to pass when using cpp as the server. -- This message was sent by Atlassian JIRA (v6.3.4#6332)