[
https://issues.apache.org/jira/browse/THRIFT-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610343#comment-14610343
]
ASF GitHub Bot commented on THRIFT-3211:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/532#discussion_r33682913
--- Diff: test/tests.json ---
@@ -332,7 +332,9 @@
"ip"
],
"protocols": [
- "binary"
+ "binary",
+ "compact",
+ "binary:accel"
--- End diff --
Note: JSON is broken against every server, should get a Jira ticket.
> Add make cross support for php TCompactProtocol
> -----------------------------------------------
>
> Key: THRIFT-3211
> URL: https://issues.apache.org/jira/browse/THRIFT-3211
> Project: Thrift
> Issue Type: Test
> Components: PHP - Library, Test Suite
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Minor
>
> In working on THRIFT-878 I found that the PHP client does not test
> TCompactProtocol in {{make cross}}. I fixed the php test client locally and
> was able to get it to pass when using cpp as the server.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
