Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/598#discussion_r38551876
--- Diff: build/cmake/DefineOptions.cmake ---
@@ -62,8 +62,10 @@ endif()
find_package(OpenSSL QUIET)
CMAKE_DEPENDENT_OPTION(WITH_OPENSSL "Build with OpenSSL support" ON
"OPENSSL_FOUND" OFF)
-option(WITH_BOOSTTHREADS "Build with Boost thread support" OFF)
option(WITH_STDTHREADS "Build with C++ std::thread support" OFF)
+CMAKE_DEPENDENT_OPTION(WITH_BOOSTTHREADS "Build with Boost threads
support" ON
--- End diff --
Looks like a good idea for Windows.
For *nix, pthread has been the default, and IMO it should remain so because:
* *configure.ac* option states boost thread is experimental.
* In my experience, Thrift pthread implementation has better performance
(although negligible for most cases) than that of boost or std-thread on Linux.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
