Github user nsuke commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/598#discussion_r38552069
  
    --- Diff: lib/cpp/test/qt/CMakeLists.txt ---
    @@ -18,11 +18,15 @@
     #
     
     set(CMAKE_AUTOMOC ON)
    -find_package(Qt5 REQUIRED COMPONENTS Test)
    +find_package(Qt5 REQUIRED COMPONENTS Test Network)
    --- End diff --
    
    Network module should be already found either by non-test part of 
cpp/CMakeLists.txt or qt5/CMakeLists.txt before reaching here.
    I'm not particularly against being explicit if it's your intention, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to