[ https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14962501#comment-14962501 ]
ASF GitHub Bot commented on THRIFT-3393: ---------------------------------------- GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/656 THRIFT-3393 Introducing i8 to provide consistent set of Thrift integers THRIFT-3393 Introducing i8 to provide consistent set of Thrift integers Client: Compiler (general) Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-3393 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/656.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #656 ---- commit debe89e99a2be191bcc5d70a886bdb12153af293 Author: Jens Geyer <je...@apache.org> Date: 2015-10-16T18:21:54Z THRIFT-3393 Introducing i8 to provide consistent set of Thrift integers Client: Compiler (general) Patch: Jens Geyer ---- > Introduce i8 to provide consistent set of Thrift IDL integer types > ------------------------------------------------------------------ > > Key: THRIFT-3393 > URL: https://issues.apache.org/jira/browse/THRIFT-3393 > Project: Thrift > Issue Type: Improvement > Components: Compiler (General) > Reporter: Jens Geyer > Assignee: Jens Geyer > Labels: i8 > > In following up a [recent email > discussion|https://mail-archives.apache.org/mod_mbox/thrift-dev/201412.mbox/%3cdub110-ds46454ddd3a90974be62d69b1...@phx.gbl%3e] > and the consistent stream of problems with the [signedness of the Thrift IDL > {{byte}} datatype|https://thrift.apache.org/docs/types], we should > * add an {{i8}} data type to provide a consistent set > * keep the {{byte}} type for the sake of compatibility > * internally map all references to {{byte}} to {{i8}} > I'm hesitant though about printing a warning for {{byte}} at this stage. A > lot of third-party-tools rely on Thrift IDL and I don't want to introduce any > breaking changes. IMHO we should promote i8 instead of byte wherever > possible, but not hammer that nail too much. > This patch is solely about the changes needed in the IDL and the compiler > infrastructure, changing only what's necessary in the various target > languages to let {{make check}} succeed. Any additional changes to be made in > the language libs should be added as a sub-task as necessary. This procedure > allows us to make the changes in a more granular way while still maintaining > a shippable product. -- This message was sent by Atlassian JIRA (v6.3.4#6332)