[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965857#comment-14965857
]
Hudson commented on THRIFT-3393:
--------------------------------
SUCCESS: Integrated in Thrift #1694 (See
[https://builds.apache.org/job/Thrift/1694/])
THRIFT-3393 Introducing i8 to provide consistent set of Thrift integers (jensg:
rev 40c28d3310ff5f18c4af085592ac658f56b8daeb)
* compiler/cpp/src/parse/t_scope.h
* compiler/cpp/src/generate/t_html_generator.cc
* compiler/cpp/src/generate/t_js_generator.cc
* compiler/cpp/src/generate/t_hs_generator.cc
* compiler/cpp/src/generate/t_dart_generator.cc
* compiler/cpp/src/generate/t_javame_generator.cc
* compiler/cpp/src/generate/t_swift_generator.cc
* compiler/cpp/src/generate/t_c_glib_generator.cc
* compiler/cpp/src/main.h
* lib/erl/src/thrift_protocol.erl
* compiler/cpp/src/generate/t_st_generator.cc
* compiler/cpp/src/generate/t_d_generator.cc
* compiler/cpp/src/generate/t_haxe_generator.cc
* compiler/cpp/src/generate/t_csharp_generator.cc
* test/ThriftTest.thrift
* lib/erl/include/thrift_constants.hrl
* compiler/cpp/src/generate/t_cpp_generator.cc
* compiler/cpp/src/generate/t_lua_generator.cc
* compiler/cpp/src/generate/t_ocaml_generator.cc
* compiler/cpp/src/parse/t_base_type.h
* lib/erl/src/thrift_json_protocol.erl
* compiler/cpp/src/generate/t_java_generator.cc
* compiler/cpp/src/main.cc
* compiler/cpp/src/generate/t_xsd_generator.cc
* compiler/cpp/src/generate/t_as3_generator.cc
* compiler/cpp/src/generate/t_php_generator.cc
* compiler/cpp/src/generate/t_go_generator.cc
* compiler/cpp/src/generate/t_cocoa_generator.cc
* compiler/cpp/src/generate/t_rb_generator.cc
* compiler/cpp/src/generate/t_delphi_generator.cc
* compiler/cpp/src/thrifty.yy
* compiler/cpp/src/generate/t_erl_generator.cc
* compiler/cpp/src/generate/t_py_generator.cc
* compiler/cpp/src/thriftl.ll
* compiler/cpp/src/globals.h
* compiler/cpp/src/generate/t_perl_generator.cc
> Introduce i8 to provide consistent set of Thrift IDL integer types
> ------------------------------------------------------------------
>
> Key: THRIFT-3393
> URL: https://issues.apache.org/jira/browse/THRIFT-3393
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Labels: i8
> Fix For: 1.0
>
>
> In following up a [recent email
> discussion|https://mail-archives.apache.org/mod_mbox/thrift-dev/201412.mbox/%3cdub110-ds46454ddd3a90974be62d69b1...@phx.gbl%3e]
> and the consistent stream of problems with the [signedness of the Thrift IDL
> {{byte}} datatype|https://thrift.apache.org/docs/types], we should
> * add an {{i8}} data type to provide a consistent set
> * keep the {{byte}} type for the sake of compatibility
> * internally map all references to {{byte}} to {{i8}}
> I'm hesitant though about printing a warning for {{byte}} at this stage. A
> lot of third-party-tools rely on Thrift IDL and I don't want to introduce any
> breaking changes. IMHO we should promote i8 instead of byte wherever
> possible, but not hammer that nail too much.
> This patch is solely about the changes needed in the IDL and the compiler
> infrastructure, changing only what's necessary in the various target
> languages to let {{make check}} succeed. Any additional changes to be made in
> the language libs should be added as a sub-task as necessary. This procedure
> allows us to make the changes in a more granular way while still maintaining
> a shippable product.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
