[
https://issues.apache.org/jira/browse/THRIFT-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087472#comment-15087472
]
ASF GitHub Bot commented on THRIFT-3528:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169677418
Sure, that's the whole point of putting this as a PR.
In a nutshell I believe it does not change any behavior except that it
fixes 3 warnings pasted to JIRA.
Those 3 rules are exact duplicates that never match because precedent ones
(Line 182, 267 and 409) always match over these.
You may want to also check `git blame` output to see which patches caused
these. It seems simple mistakes to me.
> Fix warnings in thrift.ll
> -------------------------
>
> Key: THRIFT-3528
> URL: https://issues.apache.org/jira/browse/THRIFT-3528
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Priority: Trivial
>
> {code}
> /thrift/compiler/cpp/src/thriftl.ll:271: warning, rule cannot be matched
> /thrift/compiler/cpp/src/thriftl.ll:290: warning, rule cannot be matched
>
>
> /thrift/compiler/cpp/src/thriftl.ll:414: warning, rule cannot be matched
> {code}
> Seeing the code, the rules were redundant and no use at all as suggested by
> the warning messages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
