[ 
https://issues.apache.org/jira/browse/THRIFT-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087590#comment-15087590
 ] 

ASF GitHub Bot commented on THRIFT-3528:
----------------------------------------

Github user hcorg commented on the pull request:

    https://github.com/apache/thrift/pull/778#issuecomment-169698270
  
    Comment is from older version, which for some reason passed all unexpected 
tokens to bison.. strange :)
    
    So with comment removal this patch has my +1 :+1: 



> Fix warnings in thrift.ll
> -------------------------
>
>                 Key: THRIFT-3528
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3528
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (General)
>            Reporter: Aki Sukegawa
>            Assignee: Aki Sukegawa
>            Priority: Trivial
>
> {code}
> /thrift/compiler/cpp/src/thriftl.ll:271: warning, rule cannot be matched
> /thrift/compiler/cpp/src/thriftl.ll:290: warning, rule cannot be matched      
>                                                                               
>                 
> /thrift/compiler/cpp/src/thriftl.ll:414: warning, rule cannot be matched
> {code}
> Seeing the code, the rules were redundant and no use at all as suggested by 
> the warning messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to