[
https://issues.apache.org/jira/browse/THRIFT-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087585#comment-15087585
]
ASF GitHub Bot commented on THRIFT-3528:
----------------------------------------
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/778#issuecomment-169697734
235f8b5899b2c5b75cb83975695da1377f0cac0c is the commit that added current
(preceding) one which is THRIFT-1274.
According to the JIRA ticket
> Currently, if the thrift lexer encounters a token it does not expect, it
prints the token it to stdout and continues. (This is the default behavior of
flex when a token is unmatched.) This updates thriftl.ll to fail with an error
message when it sees an unexpected character.
So according to this, older one does nothing and we wanted Thrift compiler
to fail on unexpected token, which seems perfectly reasonable to me.
Removing the comment makes sense. `unexpected_token` call is already more
informative than the comment.
> Fix warnings in thrift.ll
> -------------------------
>
> Key: THRIFT-3528
> URL: https://issues.apache.org/jira/browse/THRIFT-3528
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Priority: Trivial
>
> {code}
> /thrift/compiler/cpp/src/thriftl.ll:271: warning, rule cannot be matched
> /thrift/compiler/cpp/src/thriftl.ll:290: warning, rule cannot be matched
>
>
> /thrift/compiler/cpp/src/thriftl.ll:414: warning, rule cannot be matched
> {code}
> Seeing the code, the rules were redundant and no use at all as suggested by
> the warning messages.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
