[ https://issues.apache.org/jira/browse/THRIFT-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146286#comment-15146286 ]
ASF GitHub Bot commented on THRIFT-3629: ---------------------------------------- GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/861 THRIFT-3629 Parser sets exitcode on errors, but generator does not Client: Compiler (general) Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-3629 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/861.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #861 ---- commit ad5732fd5f9d2423e31ed06dc736ef3264a2c34f Author: Jens Geyer <je...@apache.org> Date: 2016-02-13T22:25:11Z THRIFT-3629 Parser sets exitcode on errors, but generator does not Client: Compiler (general) Patch: Jens Geyer ---- > Parser sets exitcode on errors, but generator does not > ------------------------------------------------------ > > Key: THRIFT-3629 > URL: https://issues.apache.org/jira/browse/THRIFT-3629 > Project: Thrift > Issue Type: Bug > Components: Compiler (General) > Reporter: Jens Geyer > Assignee: Jens Geyer > > In {{main.cc}}, the {{parse()}} function and the {{generate()}} function do > behave inconsistently w/regard to exceptions being thrown. > Both functions catch the exception, but ... > * {{parse()}} exits with code 1 and prints the error to {{stderr}} > * {{generate()}} only prints the error to {{stdout}} and finally exits with > code 0 > Proposal is to change {{generate()}} similar to the behaviour of {{parse()}}. > Patch is ready, follows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)