[ 
https://issues.apache.org/jira/browse/THRIFT-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146594#comment-15146594
 ] 

Hudson commented on THRIFT-3629:
--------------------------------

SUCCESS: Integrated in Thrift-precommit #151 (See 
[https://builds.apache.org/job/Thrift-precommit/151/])
THRIFT-3629 Parser sets exitcode on errors, but the generator does not (jensg: 
[https://github.com/apache/thrift/commit/d4722d9c48318d1077b16b557f685d0b1aab16d4])
* compiler/cpp/src/main.cc


> Parser sets exitcode on errors, but generator does not
> ------------------------------------------------------
>
>                 Key: THRIFT-3629
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3629
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (General)
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>             Fix For: 1.0
>
>
> In {{main.cc}}, the {{parse()}} function and the {{generate()}} function do 
> behave inconsistently w/regard to exceptions being thrown. 
> Both functions catch the exception, but ...
>  * {{parse()}} exits with code 1 and prints the error to {{stderr}}
>  * {{generate()}} only prints the error to {{stdout}} and finally exits with 
> code 0
> Proposal is to change {{generate()}} similar to the behaviour of {{parse()}}. 
> Patch is ready, follows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to