[
https://issues.apache.org/jira/browse/THRIFT-3629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146494#comment-15146494
]
Hudson commented on THRIFT-3629:
--------------------------------
SUCCESS: Integrated in Thrift-precommit #137 (See
[https://builds.apache.org/job/Thrift-precommit/137/])
THRIFT-3629 Parser sets exitcode on errors, but the generator does not (jensg:
[https://github.com/apache/thrift/commit/3131cb5b9bb50a3b33254aec19e72ef41b56e772])
* compiler/cpp/src/main.cc
> Parser sets exitcode on errors, but generator does not
> ------------------------------------------------------
>
> Key: THRIFT-3629
> URL: https://issues.apache.org/jira/browse/THRIFT-3629
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (General)
> Reporter: Jens Geyer
> Assignee: Jens Geyer
>
> In {{main.cc}}, the {{parse()}} function and the {{generate()}} function do
> behave inconsistently w/regard to exceptions being thrown.
> Both functions catch the exception, but ...
> * {{parse()}} exits with code 1 and prints the error to {{stderr}}
> * {{generate()}} only prints the error to {{stdout}} and finally exits with
> code 0
> Proposal is to change {{generate()}} similar to the behaviour of {{parse()}}.
> Patch is ready, follows.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
