Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/840#discussion_r52841869
--- Diff: lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java ---
@@ -225,8 +231,13 @@ private void cleanUpAndFireCallback(SelectionKey key) {
key.interestOps(0);
// this ensures that the TAsyncMethod instance doesn't hang around
key.attach(null);
--- End diff --
AFAIK, key is not removed from `selector.keys()` unless `key.cancel()` is
called, so `interestOps(0)` and `attach(null)` is not enough (maybe wrong
assumption ?).
Do you happen to have any idea why the original code does not call
`cancel()` for the success path here ?
As your intention here seems to be to prevent `key.cancel()` in
`transition()` for the error path, I thought you might know about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
